Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed module disappearing outside pr area #1437

Open
wants to merge 1 commit into
base: image_v3.1
Choose a base branch
from
Open

Fixed module disappearing outside pr area #1437

wants to merge 1 commit into from

Conversation

tignear
Copy link

@tignear tignear commented Feb 15, 2024

Assume that the static area contains the following modules.

  • processor(DFX)
  • processor_enable
  • xyz

When I reconfigured the "processor", the "processor_enable" module disappeared.
It should be correct that it doesn't disappear, so I'll fix it that way.

@mariodruiz
Copy link
Collaborator

Hi @tignear,

Thank you for your contribution. We will review this for the next release.

@skalade skalade changed the base branch from master to image_v3.1 May 1, 2024 16:53
@STFleming
Copy link
Collaborator

Hi @tignear, would it be possible to get a .hwh file so that we can investigate this issue that this PR fixes before evaluating if we can merge it onto the next release branch.

Thanks so much.

@tignear
Copy link
Author

tignear commented May 23, 2024

project.zip

ol = Overlay("toplevel.bit")
ol.pipeline_enable # => ok
ol.pipeline.download("image_processor_id_partial.bit")
ol.pipeline_enable
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Input In [13], in <cell line: 1>()
----> 1 ol.pipeline_enable

File /usr/local/share/pynq-venv/lib/python3.10/site-packages/pynq/overlay.py:363, in Overlay.__getattr__(self, key)
    358 """Overload of __getattr__ to return a driver for an IP or
    359 hierarchy. Throws an `RuntimeError` if the overlay is not loaded.
    360 
    361 """
    362 if self.is_loaded():
--> 363     return getattr(self._ip_map, key)
    364 else:
    365     raise RuntimeError("Overlay not currently loaded")

File /usr/local/share/pynq-venv/lib/python3.10/site-packages/pynq/overlay.py:931, in _IPMap.__getattr__(self, key)
    929     return mem
    930 else:
--> 931     raise AttributeError(
    932         "Could not find IP or hierarchy {} in overlay".format(key)
    933     )

AttributeError: Could not find IP or hierarchy pipeline_enable in overlay

@mariodruiz
Copy link
Collaborator

Hi @tignear,

Can you try to rename pipeline_enable to something that does not start with pipeline?

Which board are you using?

@tignear
Copy link
Author

tignear commented May 24, 2024 •
edited
Loading

Can you try to rename pipeline_enable to something that does not start with pipeline?

It will work if I do that.

Which board are you using?

https://digilent.com/reference/programmable-logic/pynq-z1/start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tignear @mariodruiz @STFleming